----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1217/#review2797 -----------------------------------------------------------
Ship it! Ship It! - Ali Saidi On May 23, 2012, 6:35 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1217/ > ----------------------------------------------------------- > > (Updated May 23, 2012, 6:35 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9023:4f93374a2efa > --------------------------- > Bus: Turn the PortId into a transport function parameter > > The main aim of this patch is to arrive at a suitable port interface > for vector ports, including both the packet and the port id. This > patch changes the bus transport functions > (recvFunctional/Atomic/Timing) to require a PortId parameter > indicating the source port. Previously this information was passed by > setting the source field of the packet, and this is only required in > the case of a timing request. > > With this patch, the use of the source and destination field is also > more restrictive, as they are only needed for timing accesses. The > modifications to these fields for atomic snoops is now removed > entirely, also making minor modifications to the cache. > > > Diffs > ----- > > src/mem/bus.hh 4fbbd05809d2 > src/mem/bus.cc 4fbbd05809d2 > src/mem/cache/cache_impl.hh 4fbbd05809d2 > > Diff: http://reviews.gem5.org/r/1217/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
