-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1185/#review2800
-----------------------------------------------------------


I'm not overwhelmed with the comment/code ratio, but for the rest it looks good.

- Andreas Hansson


On May 11, 2012, 8:51 a.m., Nathan Binkert wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/1185/
> -----------------------------------------------------------
> 
> (Updated May 11, 2012, 8:51 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Description
> -------
> 
> stats: rework the output portion of stats so that they use python
> This is a major change to the stats package for the display portion of
> statistics.  This allows people to much more easily output stats in
> alternative formats as well as do more complicated analysis of stats.
> The package can be used to take the output of multiple runs or samples
> and average across them and then calculate values.
> 
> 
> Diffs
> -----
> 
>   src/base/statistics.hh f681719e2e992a5bd6b559ac9c1e489999a3fa5a 
>   src/python/SConscript f681719e2e992a5bd6b559ac9c1e489999a3fa5a 
>   src/python/m5/stats/__init__.py f681719e2e992a5bd6b559ac9c1e489999a3fa5a 
>   src/python/m5/stats/context.py PRE-CREATION 
>   src/python/m5/stats/display.py PRE-CREATION 
>   src/python/m5/stats/info.py PRE-CREATION 
>   src/python/m5/util/registry.py PRE-CREATION 
>   src/python/swig/stats.i f681719e2e992a5bd6b559ac9c1e489999a3fa5a 
> 
> Diff: http://reviews.gem5.org/r/1185/diff/
> 
> 
> Testing
> -------
> 
> All regressions pass.
> 
> 
> Thanks,
> 
> Nathan Binkert
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to