----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1216/ -----------------------------------------------------------
(Updated May 29, 2012, 3:26 a.m.) Review request for Default. Summary (updated) ----------------- Packet: Unify the use of PortID in packet and port Description (updated) ------- Changeset 9031:d9e932f46019 --------------------------- Packet: Unify the use of PortID in packet and port This patch removes the Packet::NodeID typedef and unifies it with the Port::PortId. The src and dest fields in the packet are used to hold a port id (e.g. in the bus), and thus the two should actually be the same. The typedef PortID is now global (in base/types.hh) and aligned with the ThreadID in terms of capitalisation and naming of the InvalidPortID constant. Before this patch, two flags were used for valid destination and source, rather than relying on a named value (InvalidPortID), and this is now redundant, as the src and dest field themselves are sufficient to tell whether the current value is a valid port identifier or not. Consequently, the VALID_SRC and VALID_DST are removed. As part of the cleaning up, a number of int parameters and local variables are updated to use PortID. Note that Ruby still has its own NodeID typedef. Furthermore, the MemObject getMaster/SlavePort still has an int idx parameter with a default value of -1 which should eventually change to PortID idx = InvalidPortID. Diffs (updated) ----- src/base/types.hh f92783bcfd25 src/cpu/testers/directedtest/RubyDirectedTester.hh f92783bcfd25 src/cpu/testers/rubytest/RubyTester.hh f92783bcfd25 src/mem/bridge.hh f92783bcfd25 src/mem/bus.hh f92783bcfd25 src/mem/bus.cc f92783bcfd25 src/mem/cache/cache_impl.hh f92783bcfd25 src/mem/packet.hh f92783bcfd25 src/mem/port.hh f92783bcfd25 src/mem/port.cc f92783bcfd25 Diff: http://reviews.gem5.org/r/1216/diff/ Testing ------- util/regress all passing (disregarding t1000 and eio) Thanks, Andreas Hansson _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
