----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1238/#review2858 -----------------------------------------------------------
Interesting. I'd click ship it, but it seems that maybe a little bit more thought on how we can make the checkpoint version number stuff actually work in practice would be good. src/sim/root.cc <http://reviews.gem5.org/r/1238/#comment3145> Since this is only ever used here, you could simply do this and avoid the change to config/the_isa.hh: #define __STRINGIFY(X) #X std::string isa = __STRINGIFY(TheISA); #undef __STRINGIFY src/sim/serialize.hh <http://reviews.gem5.org/r/1238/#comment3144> It seems that this could easily get out of sync. Any ideas how to prevent that from happening? Be cool if we could somehow hash the various checkpoint functions. Should we do the versioning on a per-object basis? That way a change in one isa wouldn't affect another, and it might be more likely that someone notices the need to update the version number for an object checkpoint. - Nathan Binkert On May 30, 2012, 10:01 a.m., Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1238/ > ----------------------------------------------------------- > > (Updated May 30, 2012, 10:01 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9041:1f633efe95fe > --------------------------- > sim: Provide a framework for detecting out of data checkpoints and migrating > them. > > > Diffs > ----- > > src/SConscript 8b9f227b64d8 > src/sim/root.hh 8b9f227b64d8 > src/sim/root.cc 8b9f227b64d8 > src/sim/serialize.hh 8b9f227b64d8 > util/cpt_upgrader.py PRE-CREATION > > Diff: http://reviews.gem5.org/r/1238/diff/ > > > Testing > ------- > > > Thanks, > > Ali Saidi > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
