> On June 3, 2012, 2:24 p.m., Nilay Vaish wrote: > > src/arch/x86/isa_traits.hh, line 75 > > <http://reviews.gem5.org/r/1235/diff/1/?file=27045#file27045line75> > > > > Why do you need to move this from isa_traits to x86_traits? > > How are you deciding what goes where? Why do we need two files? > > Did you forgot add x86/isa_traits.cc to the diff?
x86_traits.hh is for things which are like what goes in isa_traits.hh but are specific to x86 and aren't expected to be defined in other ISAs. It makes sense to have this defined for x86 because it's used in a lot of places, but it's not defined by x86 for consumption outside the ISA any more. In the future I'd like there to be a more well defined boundary between internal and external ISA stuff. I did accidentally leave off isa_traits.cc for x86. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1235/#review2883 ----------------------------------------------------------- On May 29, 2012, 2:59 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1235/ > ----------------------------------------------------------- > > (Updated May 29, 2012, 2:59 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9029:ed1b0bf94c92 > --------------------------- > ISA: Turn the ExtMachInst NoopMachinst into the StaticInstPtr NoopStaticInst. > > This eliminates a use of the ExtMachInst type outside of the ISAs. > > > Diffs > ----- > > src/arch/alpha/SConscript f92783bcfd25 > src/arch/alpha/isa_traits.hh f92783bcfd25 > src/arch/alpha/isa_traits.cc PRE-CREATION > src/arch/mips/SConscript f92783bcfd25 > src/arch/mips/isa_traits.hh f92783bcfd25 > src/arch/mips/isa_traits.cc PRE-CREATION > src/arch/power/SConscript f92783bcfd25 > src/arch/power/isa_traits.hh f92783bcfd25 > src/arch/power/isa_traits.cc PRE-CREATION > src/arch/sparc/SConscript f92783bcfd25 > src/arch/sparc/isa_traits.hh f92783bcfd25 > src/arch/sparc/isa_traits.cc PRE-CREATION > src/arch/x86/SConscript f92783bcfd25 > src/arch/x86/isa_traits.hh f92783bcfd25 > src/arch/x86/x86_traits.hh f92783bcfd25 > src/cpu/o3/fetch_impl.hh f92783bcfd25 > > Diff: http://reviews.gem5.org/r/1235/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
