----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1259/#review2922 -----------------------------------------------------------
Ship it! Ship It! - Andreas Hansson On June 6, 2012, 3:12 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1259/ > ----------------------------------------------------------- > > (Updated June 6, 2012, 3:12 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9060:dfc6c6ae6175 > --------------------------- > Config: Remove setMipsOptions > As status matrix, MIPS fs does not work. Hence, these options are not > required. Secondly, the function is setting param values for a CPU class. > This seems strange, should probably be done in a different way. > > > Diffs > ----- > > configs/common/FSConfig.py cc47e11ccec1 > configs/example/fs.py cc47e11ccec1 > > Diff: http://reviews.gem5.org/r/1259/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
