Hi Nilay, I added that additional check, but I suppose it could be removed and replaced with a check in the init that if forwardSnoops is true, make sure the connected master is snooping.
Concerning your issue, does it receive an atomic snoop? If so the CPU should not be complaining as recvAtomicSnoop in the atomic CPU just returns 0 and does nothing more. Andreas -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Nilay Vaish Sent: 08 June 2012 17:11 To: gem5 Developer List Subject: Re: [gem5-dev] Snoop forwarding in caches I understand that forwardsSnoops should be set only if the cache should be forwarding snoops. In case of functional accesses (in the function functionalAccess()), the check is both on whether the cache forwards snoops and that whether the master port accepts snoop requests. So, I thought may the same check is required in case of atomic/timing snoop requests. I am trying to switch from timing mode to atomic mode. After the switch, the icache port of the atomic cpu receives a snoop request and it panics at that point. Can you point out why this may be happening? Thanks Nilay On Fri, 8 Jun 2012, Uri Wiener wrote: > Hi Nilay, > As I see it, it's now the receiving end's responsibility to implement > recvTimingSnoopReq, possibly a void function (e.g. as done > at src/cpu/o3/cpu.hh, src/arch/x86/pagetable_walker.hh, > src/cpu/simple/timing.hh). > So the snoop is always forwarded if forwardSnoops==true (in vain in such > cases). If recvTimingSnoopReq wasn't implemented, you'll end up with > port.hh's recvTimingSnoopReq, and will panic("%s was not expecting a timing > snoop request\n", name()). > I hope this correctly motivates the current implementation. > Regards, > Uri > > 2012/6/8 Nilay Vaish <[email protected]> > >> Hi >> >> On line 1188, function handleSnoop(), file cache_impl.hh, there is a check >> on whether or not to forward snoops. Should there be a check there on >> whether or not the cpu side port is accepts snoop requests? >> >> -- >> Nilay >> ______________________________**_________________ >> gem5-dev mailing list >> [email protected] >> http://m5sim.org/mailman/**listinfo/gem5-dev<http://m5sim.org/mailman/listinfo/gem5-dev> >> > _______________________________________________ > gem5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/gem5-dev > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
