----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1220/#review2845 -----------------------------------------------------------
src/arch/x86/decoder.hh <http://reviews.gem5.org/r/1220/#comment3140> I'm kind of confused by your data structure here... why have a separate 'chunks' variable instead of using bytes.size() (which I think is what chunks is tracking, no?)? And does 'masks' ever represent anything other than a contiguous sequence of bytes? Intuitively I'd think the cache entry would be something like std::pair<StaticInstPtr, std::vector<uint8_t> >, and I'm not following why it's so much more than that. - Steve Reinhardt On May 25, 2012, 3:45 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1220/ > ----------------------------------------------------------- > > (Updated May 25, 2012, 3:45 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9025:bfe6203ca3d5 > --------------------------- > X86: Move address based decode caching in front of the predecoder. > > The predecoder in x86 does a lot of work, most of which can be skipped if the > decoder cache is put in front of it. > > > Diffs > ----- > > src/arch/x86/decoder.hh bb25e7646c41 > src/arch/x86/decoder.cc bb25e7646c41 > src/arch/x86/isa.hh bb25e7646c41 > src/arch/x86/isa.cc bb25e7646c41 > > Diff: http://reviews.gem5.org/r/1220/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
