----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1285/ -----------------------------------------------------------
Review request for Default. Description ------- Changeset 9073:da6c24cdff99 --------------------------- ruby: changes how Topologies are created Instead of just passing a list of controllers to the makeTopology function in src/mem/ruby/network/topologies/<Topo>.py we pass in a function pointer which knows how to make the topology, possibly with some extra state set in the configs/ruby/<protocol>.py file. Thus, we can move all of the files from network/topologies to configs/topologies. A new class BaseTopology is added which all topologies in configs/topologies must inheirit from and follow its API. Diffs ----- configs/example/ruby_direct_test.py d8e5ca139d7c24eeb665ac0aab41e180886278cb configs/example/ruby_fs.py d8e5ca139d7c24eeb665ac0aab41e180886278cb configs/example/ruby_mem_test.py d8e5ca139d7c24eeb665ac0aab41e180886278cb configs/example/ruby_network_test.py d8e5ca139d7c24eeb665ac0aab41e180886278cb configs/example/ruby_random_test.py d8e5ca139d7c24eeb665ac0aab41e180886278cb configs/example/se.py d8e5ca139d7c24eeb665ac0aab41e180886278cb configs/ruby/MESI_CMP_directory.py d8e5ca139d7c24eeb665ac0aab41e180886278cb configs/ruby/MI_example.py d8e5ca139d7c24eeb665ac0aab41e180886278cb configs/ruby/MOESI_CMP_directory.py d8e5ca139d7c24eeb665ac0aab41e180886278cb configs/ruby/MOESI_CMP_token.py d8e5ca139d7c24eeb665ac0aab41e180886278cb configs/ruby/MOESI_hammer.py d8e5ca139d7c24eeb665ac0aab41e180886278cb configs/ruby/Network_test.py d8e5ca139d7c24eeb665ac0aab41e180886278cb configs/ruby/Ruby.py d8e5ca139d7c24eeb665ac0aab41e180886278cb configs/topologies/BaseTopology.py PRE-CREATION configs/topologies/Cluster.py PRE-CREATION src/mem/ruby/network/topologies/Crossbar.py d8e5ca139d7c24eeb665ac0aab41e180886278cb src/mem/ruby/network/topologies/Mesh.py d8e5ca139d7c24eeb665ac0aab41e180886278cb src/mem/ruby/network/topologies/MeshDirCorners.py d8e5ca139d7c24eeb665ac0aab41e180886278cb src/mem/ruby/network/topologies/Pt2Pt.py d8e5ca139d7c24eeb665ac0aab41e180886278cb src/mem/ruby/network/topologies/SConscript d8e5ca139d7c24eeb665ac0aab41e180886278cb src/mem/ruby/network/topologies/TopologyCreator.py PRE-CREATION src/mem/ruby/network/topologies/Torus.py d8e5ca139d7c24eeb665ac0aab41e180886278cb src/python/m5/SimObject.py d8e5ca139d7c24eeb665ac0aab41e180886278cb Diff: http://reviews.gem5.org/r/1285/diff/ Testing ------- Thanks, Brad Beckmann _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
