----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1288/#review3038 -----------------------------------------------------------
src/mem/ruby/system/System.cc <http://reviews.gem5.org/r/1288/#comment3236> Can you add a comment about why this is needed? Intuitively you'd think that the controller would already be reset at startup... (I believe I know the answer, just want to see it recorded for posterity.) - Steve Reinhardt On July 2, 2012, 10:43 p.m., Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1288/ > ----------------------------------------------------------- > > (Updated July 2, 2012, 10:43 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9076:11422560e100 > --------------------------- > ruby: adds reset function to Ruby memory controllers > > > Diffs > ----- > > src/mem/ruby/system/MemoryControl.hh > d8e5ca139d7c24eeb665ac0aab41e180886278cb > src/mem/ruby/system/MemoryControl.cc > d8e5ca139d7c24eeb665ac0aab41e180886278cb > src/mem/ruby/system/RubyMemoryControl.hh PRE-CREATION > src/mem/ruby/system/RubyMemoryControl.cc PRE-CREATION > src/mem/ruby/system/System.hh d8e5ca139d7c24eeb665ac0aab41e180886278cb > src/mem/ruby/system/System.cc d8e5ca139d7c24eeb665ac0aab41e180886278cb > > Diff: http://reviews.gem5.org/r/1288/diff/ > > > Testing > ------- > > > Thanks, > > Brad Beckmann > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
