----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1296/#review3062 -----------------------------------------------------------
src/mem/tport.hh <http://reviews.gem5.org/r/1296/#comment3261> Should be queueImpl. Othweise this looks fine. - Steve Reinhardt On July 6, 2012, 6:33 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1296/ > ----------------------------------------------------------- > > (Updated July 6, 2012, 6:33 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9102:6e82c795f7c3 > --------------------------- > Port: Hide the queue implementation in SimpleTimingPort > > This patch makes the queue implementation in the SimpleTimingPort > private to avoid confusion with the protected member queue in the > QueuedSlavePort. The SimpleTimingPort provides the queue_impl to the > QueuedSlavePort and it can be accessed via the reference in the base > class. The use of the member name queue is thus no longer overloaded. > > > Diffs > ----- > > src/mem/tport.hh 5f0321c03a26 > src/mem/tport.cc 5f0321c03a26 > > Diff: http://reviews.gem5.org/r/1296/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
