----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1317/#review3118 -----------------------------------------------------------
might want to initialize to 0 and assert (result !=0) in the true case. - Ali Saidi On July 21, 2012, 9:08 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1317/ > ----------------------------------------------------------- > > (Updated July 21, 2012, 9:08 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9123:bf3f6849bae8 > --------------------------- > X86 CPUID: Return false if unknown processor family > > > Diffs > ----- > > src/arch/x86/cpuid.cc 2f6f0631af48 > > Diff: http://reviews.gem5.org/r/1317/diff/ > > > Testing > ------- > > Ran the pc-simple-timing regression test for x86, would > result in a few stat changes. > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
