----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1308/#review3132 -----------------------------------------------------------
Ship it! Looks fine to me. - Nilay Vaish On July 23, 2012, 7:45 a.m., Jason Power wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1308/ > ----------------------------------------------------------- > > (Updated July 23, 2012, 7:45 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9123:7166285d6ad2 > --------------------------- > Ruby: Clean up topology changes > Moved instantiateTopology into Ruby.py and removed the topologies directory > I'm not completely sure why the topology creation was in the src/ directory, > but I think it was because previously the python needed to be compiled. > > Also added some extra inheritance to the topologies to clean up some issues > in the legacy topologies > > > Diffs > ----- > > configs/ruby/Ruby.py 48eeef8a0997 > configs/topologies/BaseTopology.py 48eeef8a0997 > configs/topologies/Cluster.py 48eeef8a0997 > configs/topologies/Crossbar.py 48eeef8a0997 > configs/topologies/Mesh.py 48eeef8a0997 > configs/topologies/MeshDirCorners.py 48eeef8a0997 > configs/topologies/Pt2Pt.py 48eeef8a0997 > configs/topologies/Torus.py 48eeef8a0997 > src/mem/ruby/network/topologies/SConscript 48eeef8a0997 > src/mem/ruby/network/topologies/TopologyCreator.py 48eeef8a0997 > > Diff: http://reviews.gem5.org/r/1308/diff/ > > > Testing > ------- > > > Thanks, > > Jason Power > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
