----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1318/#review3133 -----------------------------------------------------------
src/sim/syscall_emul.hh <http://reviews.gem5.org/r/1318/#comment3289> Why is this fatal being changed to a warn? I'm not necessarily against this, but I thought a lot of the effort and controversy generated by this patch was that unsupported ioctl's should cause a fatal. - Marc Orr On July 22, 2012, 5:29 p.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1318/ > ----------------------------------------------------------- > > (Updated July 22, 2012, 5:29 p.m.) > > > Review request for Default. > > > Description > ------- > > [Note: this is an updated version of Marc's patch #1187. I realized I hadn't > pushed that, but when I went to test it, it didn't compile for ARM. I ended > up doing some more restructuring in the process of fixing that problem.] > > syscall emulation: Clean up ioctl handling, and implement for x86. > > Enable different whitelists for different OS/arch combinations, > since some use the generic Linux definitions only, and others > use definitions inherited from earlier Unix flavors on those > architectures. > > Also update x86 function pointers so ioctl is no longer > unimplemented on that platform. > > This patch is a revised version of Vince Weaver's earlier patch. > > > Diffs > ----- > > src/arch/alpha/linux/linux.hh UNKNOWN > src/arch/alpha/tru64/tru64.hh UNKNOWN > src/arch/arm/linux/linux.hh UNKNOWN > src/arch/mips/linux/linux.hh UNKNOWN > src/arch/power/linux/linux.hh UNKNOWN > src/arch/sparc/linux/linux.hh UNKNOWN > src/arch/x86/linux/syscalls.cc UNKNOWN > src/kern/linux/linux.hh UNKNOWN > src/sim/syscall_emul.hh UNKNOWN > > Diff: http://reviews.gem5.org/r/1318/diff/ > > > Testing > ------- > > passes 'util/regress quick' > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
