----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1325/#review3156 -----------------------------------------------------------
src/sim/syscall_emul.hh <http://reviews.gem5.org/r/1325/#comment3305> can you just turn this into a if (fd == -1) return -local_errno return process->alloc_fd(fd, path.c_str(), hostFlags, mode, false); I don't think the ?: simplifies the expression any here since it makes in wrap anyway. Free free to ignore and just commit though. - Ali Saidi On July 26, 2012, 4:57 p.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1325/ > ----------------------------------------------------------- > > (Updated July 26, 2012, 4:57 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9132:788ceacd29f9 > --------------------------- > syscall_emul: clean up open() code a bit. > > > Diffs > ----- > > src/kern/linux/linux.cc UNKNOWN > src/kern/operatingsystem.cc UNKNOWN > src/sim/syscall_emul.hh UNKNOWN > > Diff: http://reviews.gem5.org/r/1325/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
