----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1328/#review3158 -----------------------------------------------------------
Ship it! Ship It! - Andreas Hansson On July 26, 2012, 5:15 p.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1328/ > ----------------------------------------------------------- > > (Updated July 26, 2012, 5:15 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9134:55832e955e22 > --------------------------- > SETranslatingPortProxy: fix bug in tryReadString() > > Off-by-one loop termination meant that we were stuffing > the terminating '\0' into the std::string value, which > makes for difficult-to-debug string comparison failures. > > > Diffs > ----- > > src/mem/se_translating_port_proxy.cc UNKNOWN > > Diff: http://reviews.gem5.org/r/1328/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
