----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1319/#review3205 -----------------------------------------------------------
Ship it! also seems like an improvement.. a little bit of documentaiton would be great. You can put a string after the function definition. E.g.: def foo() ''' description on foo.... ''' would be great if you could do that for the functions you changed. - Ali Saidi On July 24, 2012, 8:05 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1319/ > ----------------------------------------------------------- > > (Updated July 24, 2012, 8:05 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9130:79148c86d9a5 > --------------------------- > Config: change how cpu class is set > This changes the way in which the cpu class while restoring from a > checkpoint is set. Earlier it was assumed if cpu type with which > to restore is not same as the cpu type with the which to run the > simulation, then the checkpoint should be restored with the atomic > cpu. This assumption is being dropped. The checkpoint can now be > restored with any cpu type, the default being atomic cpu. > > > Diffs > ----- > > configs/common/Simulation.py b57966a6c512 > > Diff: http://reviews.gem5.org/r/1319/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
