----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1340/#review3208 -----------------------------------------------------------
Ship it! Ship It! - Ali Saidi On Aug. 3, 2012, 8:33 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1340/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2012, 8:33 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9152:c0285a2ee142 > --------------------------- > CPU: Remove overloaded function_trace_start parameter > > This patch removes the overloading of the parameter, which seems both > redundant, and possibly incorrect. > > The inorder CPU is particularly interesting as it uses a different > name for the parameter, and never make any use of it internally. > > > Diffs > ----- > > src/cpu/BaseCPU.py b4d0bdb52694 > src/cpu/CheckerCPU.py b4d0bdb52694 > src/cpu/inorder/InOrderCPU.py b4d0bdb52694 > src/cpu/o3/O3Checker.py b4d0bdb52694 > src/cpu/ozone/OzoneCPU.py b4d0bdb52694 > src/cpu/ozone/OzoneChecker.py b4d0bdb52694 > src/cpu/ozone/SimpleOzoneCPU.py b4d0bdb52694 > > Diff: http://reviews.gem5.org/r/1340/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
