----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1339/#review3209 -----------------------------------------------------------
Ship it! Ship It! - Ali Saidi On Aug. 3, 2012, 6:46 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1339/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2012, 6:46 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9151:bfcf003c988d > --------------------------- > EventManager: Remove test for NULL pointer in constructor > > This patch tidies up the EventManager constructor and prunes a corner > case where the EventManager would initialise its eventq pointer to > NULL. This would cause segmentation faults on actual use and should > never happen. > > > Diffs > ----- > > src/sim/eventq.hh b4d0bdb52694 > > Diff: http://reviews.gem5.org/r/1339/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
