> On Aug. 5, 2012, 8:52 a.m., Ali Saidi wrote: > > src/dev/Pci.py, line 39 > > <http://reviews.gem5.org/r/1341/diff/1/?file=28578#file28578line39> > > > > we should make this a reasonable number and bump the stats. > >
Will do so in a follow up patch . At least it can be done in two unique locations now :) - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1341/#review3207 ----------------------------------------------------------- On Aug. 3, 2012, 9:07 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1341/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2012, 9:07 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9153:cf12fe204e53 > --------------------------- > Device: Remove overloaded pio_latency parameter > > This patch removes the overloading of the parameter, which seems both > redundant, and possibly incorrect. > > The PciConfigAll now also uses a Param.Latency rather than a > Param.Tick. For backwards compatibility it still sets the pio_latency > to 1 tick. All the comments have also been updated to not state that > it is in simticks when it is not necessarily the case. > > > Diffs > ----- > > src/arch/x86/X86LocalApic.py b4d0bdb52694 > src/dev/Device.py b4d0bdb52694 > src/dev/Pci.py b4d0bdb52694 > src/dev/sparc/T1000.py b4d0bdb52694 > src/dev/x86/Cmos.py b4d0bdb52694 > src/dev/x86/I8042.py b4d0bdb52694 > src/dev/x86/I82094AA.py b4d0bdb52694 > src/dev/x86/I8237.py b4d0bdb52694 > src/dev/x86/I8254.py b4d0bdb52694 > src/dev/x86/I8259.py b4d0bdb52694 > src/dev/x86/PcSpeaker.py b4d0bdb52694 > src/dev/x86/SouthBridge.py b4d0bdb52694 > > Diff: http://reviews.gem5.org/r/1341/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
