> On Aug. 2, 2012, 10:06 a.m., Andreas Hansson wrote: > > src/mem/ruby/system/MemoryControl.py, line 38 > > <http://reviews.gem5.org/r/1331/diff/1/?file=28429#file28429line38> > > > > Why not rely on a proxy and get the parent.any or similar? There should > > only be one ruby system surely. > > Nilay Vaish wrote: > How does that help?
It would make it uniform with how the System pointer is handled in the rest of the code base. It also avoids having to explicitly set it. Lastly it would ensure you've got a pointer already at creating time. Just an idea of an improvement...not a must. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1331/#review3194 ----------------------------------------------------------- On Aug. 2, 2012, 7:47 a.m., Jason Power wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1331/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2012, 7:47 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9139:8755d9aa06ac > --------------------------- > Ruby: Add RubySystem parameter to MemoryControl SimObject to guarantee that > RubySystem is created first. > > > Diffs > ----- > > configs/ruby/MESI_CMP_directory.py b4d0bdb52694 > configs/ruby/MI_example.py b4d0bdb52694 > configs/ruby/MOESI_CMP_directory.py b4d0bdb52694 > configs/ruby/MOESI_CMP_token.py b4d0bdb52694 > configs/ruby/MOESI_hammer.py b4d0bdb52694 > configs/ruby/Network_test.py b4d0bdb52694 > src/mem/ruby/system/MemoryControl.py b4d0bdb52694 > > Diff: http://reviews.gem5.org/r/1331/diff/ > > > Testing > ------- > > > Thanks, > > Jason Power > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
