----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1365/#review3292 -----------------------------------------------------------
Ship it! Ship It! - Nilay Vaish On Aug. 22, 2012, 12:22 p.m., Jason Power wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1365/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2012, 12:22 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9164:ed991ca7390f > --------------------------- > Ruby: Change DataBlock = operator to not overwrite if the assign function was > called. > > This fixes a bug where values were no propagating to > RubySystem::m_mem_vec_ptr. > This caused major issues with restoring from checkpoints when using a > protocol > which verified that the cache data was consistent with the backing store (i.e. > MOESI-hammer) > > > Diffs > ----- > > src/mem/ruby/common/DataBlock.hh 019047ead23b > src/mem/ruby/common/DataBlock.cc 019047ead23b > > Diff: http://reviews.gem5.org/r/1365/diff/ > > > Testing > ------- > > > Thanks, > > Jason Power > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
