> On Aug. 17, 2012, 9:39 a.m., Nilay Vaish wrote: > > The diff does not apply cleanly, hence it is not possible to view it. > > Nathanael Premillieu wrote: > That's strange, I have just test it on the last version of the repository > (using hg qimport) and it is applied with no problem.
Is someone able to use the patch or everyone has the same problem as Nilay ? - Nathanael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1354/#review3273 ----------------------------------------------------------- On Aug. 17, 2012, 7:24 a.m., Nathanael Premillieu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1354/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2012, 7:24 a.m.) > > > Review request for Default. > > > Description > ------- > > O3: remove some unused buggy functions (numLoadsReady) in the lsq > > > Diffs > ----- > > src/cpu/o3/lsq.hh aa76bc9f729d309c80337d26359cf43969038576 > src/cpu/o3/lsq_impl.hh aa76bc9f729d309c80337d26359cf43969038576 > src/cpu/o3/lsq_unit.hh aa76bc9f729d309c80337d26359cf43969038576 > src/cpu/o3/lsq_unit_impl.hh aa76bc9f729d309c80337d26359cf43969038576 > > Diff: http://reviews.gem5.org/r/1354/diff/ > > > Testing > ------- > > As it was unused code, there is not difference in the final program. > > > Thanks, > > Nathanael Premillieu > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
