> On Aug. 24, 2012, 3:03 p.m., Ali Saidi wrote: > > src/cpu/o3/commit_impl.hh, line 1003 > > <http://reviews.gem5.org/r/1367/diff/1/?file=29180#file29180line1003> > > > > What about just having the code in updateComStats() instead of here so > > all the stats updates go in one place?
I moved it here because that is where instDone() is called. I suppose I can move that to updateComStats as well though. - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1367/#review3316 ----------------------------------------------------------- On Aug. 24, 2012, 10:09 a.m., Anthony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1367/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2012, 10:09 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9167:4203f42d630f > --------------------------- > stats: remove duplicate instruction stats from the commit stage > > these stats are duplicates of insts/opsCommitted, cause > confusion, and are poorly named. > > > Diffs > ----- > > src/cpu/o3/commit.hh 1d983855df2c941655cda665056c6b3a8bd3d463 > src/cpu/o3/commit_impl.hh 1d983855df2c941655cda665056c6b3a8bd3d463 > > Diff: http://reviews.gem5.org/r/1367/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
