----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1351/#review3333 -----------------------------------------------------------
src/mem/AddrMapper.py <http://reviews.gem5.org/r/1351/#comment3430> Did Andreas really write this? If so, isn't there some conflict of interest in having Ali post this so Andreas can click "ship it!" on his own code? ;-) src/mem/addr_mapper.cc <http://reviews.gem5.org/r/1351/#comment3432> code after the return? I'm surprised the compiler didn't complain... (here and in the function immediately below) src/mem/addr_mapper.cc <http://reviews.gem5.org/r/1351/#comment3431> two typos in one line... - Steve Reinhardt On Aug. 16, 2012, 1:30 p.m., Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1351/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2012, 1:30 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9160:1b1d4a974531 > --------------------------- > mem: Add a gasket that allows memory ranges to be re-mapped. > > For example if DRAM is at two locations and mirrored this patch allows the > mirroring to occur. > > > Diffs > ----- > > src/mem/AddrMapper.py PRE-CREATION > src/mem/SConscript 86c0e6ca5e7c > src/mem/addr_mapper.hh PRE-CREATION > src/mem/addr_mapper.cc PRE-CREATION > src/mem/packet.hh 86c0e6ca5e7c > > Diff: http://reviews.gem5.org/r/1351/diff/ > > > Testing > ------- > > > Thanks, > > Ali Saidi > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
