----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1379/#review3398 -----------------------------------------------------------
Ship it! Not sure this ever worked, since it only seems to ever return false... - Steve Reinhardt On Aug. 29, 2012, 11:55 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1379/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2012, 11:55 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9184:60c9ef5a7bd3 > --------------------------- > Inet: Remove the SackRange and its use > > This patch aims to simplify the use of the Range class before > introducing a more elaborate AddrRegion to replace the AddrRange. The > SackRange is the only use of the range class besides address ranges, > and the removal of this use makes for an easier modification of the > range class. > > The functionlity that is removed with this patch is not used anywhere > throughout the code base. > > > Diffs > ----- > > src/base/inet.hh 42807286d6cb > src/base/inet.cc 42807286d6cb > > Diff: http://reviews.gem5.org/r/1379/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
