> On Sept. 7, 2012, 2:49 p.m., Steve Reinhardt wrote: > > src/dev/i8254xGBe.cc, line 163 > > <http://reviews.gem5.org/r/1380/diff/1/?file=29330#file29330line163> > > > > Can you elaborate on this change? It seems kind of random. > > Andreas Hansson wrote: > Since the method is writeConfig I assume it was a typo that it used to > say pioDelay. If that's wrong then I'm happy to change back. All other > read/writeConfig end with a return configDelay.
OK, that makes sense... can you add a sentence to that effect to the commit message? This leads me to the larger questions of (1) do we really need separate latencies for config-space accesses vs. non-config PIO accesses and (2) if so, couldn't we at least comment those variables in pcidev.hh, but those are outside the scope of this patch... - Steve ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1380/#review3399 ----------------------------------------------------------- On Aug. 29, 2012, 3:39 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1380/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2012, 3:39 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9187:7f0d5ac4aefd > --------------------------- > Device: Bump PIO and PCI latencies to more reasonable values > > This patch addresses a previously highlighted issue with the default > latencies used for PIO and PCI devices. The values are merely educated > guesses and might not represent the particular system you want to > model. However, the values in this patch are definitely far more > realistic than the previous ones. > > A follow-up patch will update the regression stats. > > > Diffs > ----- > > src/dev/Device.py 42807286d6cb > src/dev/Pci.py 42807286d6cb > src/dev/i8254xGBe.cc 42807286d6cb > > Diff: http://reviews.gem5.org/r/1380/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) with associated stats > updates > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
