> On Sept. 10, 2012, 8:49 a.m., Andreas Hansson wrote: > > src/mem/slicc/ast/AST.py, line 58 > > <http://reviews.gem5.org/r/1405/diff/1/?file=29601#file29601line58> > > > > Replace with a panic?
I agree, I'm happy to see the cin.get() go away, but better yet would be to replace the whole thing with a call to panic(). - Steve ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1405/#review3416 ----------------------------------------------------------- On Sept. 10, 2012, 8:34 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1405/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2012, 8:34 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9198:3eea439e46a2 > --------------------------- > Ruby Slicc: remove the call to cin.get() function > If I understand correctly, this was put in place so that a debugger can be > attached when the protocol aborts. While this sounds useful, it is a problem > when the simulation is not being actively monitored. I think it is better to > remove this. > > > Diffs > ----- > > src/mem/slicc/ast/AST.py 0281650db548 > > Diff: http://reviews.gem5.org/r/1405/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
