----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1407/#review3421 -----------------------------------------------------------
Ship it! Ship It! - Ali Saidi On Sept. 10, 2012, 9:16 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1407/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2012, 9:16 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9204:8ca660dbac7e > --------------------------- > Mem: Remove the file parameter from AbstractMemory > > This patch removes the unused file parameter from the > AbstractMemory. The patch serves to make it easier to transition to a > separation of the actual contigious host memory backing store, and the > gem5 memory controllers. > > Without the file parameter it becomes easier to hide the creation of > the mmap in the PhysicalMemory, as there are no longer any reasons to > expose the actual contigious ranges to the user. > > To the best of my knowledge there is no use of the parameter, so the > change should not affect anyone. > > > Diffs > ----- > > src/mem/AbstractMemory.py 0281650db548 > src/mem/abstract_mem.cc 0281650db548 > > Diff: http://reviews.gem5.org/r/1407/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
