Hey guys, I just got done re-running these, and the stats updates for the tests that I missed are consistent with Andreas' here (I've been unable to establish why these were not updated when I put together my original patch). Regarding the new values of the stats, all of the Ruby regression stats changes here make sense.
I'm not clear on the need to update tests/long/fs/10.linux-boot/ref/x86/linux/pc-o3-timing/stats.txt. It looks like the only stats that changed here are the host_* stats, which shouldn't warrant an update. In addition to the stats.txt and ruby.stats files, I think the config.ini files should be updated also, since the clock variable was added to the memory controller. Joel On Mon, Sep 10, 2012 at 11:02 AM, Nilay Vaish <[email protected]> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1406/#review3419 > ----------------------------------------------------------- > > > You need to include changes to ruby.stats and the one FS regression that > uses Ruby. > > - Nilay Vaish > > > On Sept. 10, 2012, 8:50 a.m., Andreas Hansson wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > http://reviews.gem5.org/r/1406/ > > ----------------------------------------------------------- > > > > (Updated Sept. 10, 2012, 8:50 a.m.) > > > > > > Review request for Default. > > > > > > Description > > ------- > > > > Changeset 9205:02ee23df7ac9 > > --------------------------- > > Ruby: Bump the stats after recent memory controller changes > > > > This patch simply bumps the stats to avoid having failing > > regressions. Someone with more insight in the changes should verify > > that these differences all make sense. > > > > > > Diffs > > ----- > > > > tests/long/fs/10.linux-boot/ref/x86/linux/pc-o3-timing/stats.txt > 0281650db548 > > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_token/stats.txt > 0281650db548 > > > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby-MOESI_CMP_token/stats.txt > 0281650db548 > > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby/stats.txt > 0281650db548 > > tests/quick/se/00.hello/ref/mips/linux/simple-timing-ruby/stats.txt > 0281650db548 > > tests/quick/se/00.hello/ref/sparc/linux/simple-timing-ruby/stats.txt > 0281650db548 > > tests/quick/se/00.hello/ref/x86/linux/simple-timing-ruby/stats.txt > 0281650db548 > > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_CMP_token/stats.txt > 0281650db548 > > > > Diff: http://reviews.gem5.org/r/1406/diff/ > > > > > > Testing > > ------- > > > > Re-ran the affected regressions > > > > > > Thanks, > > > > Andreas Hansson > > > > > > _______________________________________________ > gem5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/gem5-dev > -- Joel Hestness PhD Student, Computer Architecture Dept. of Computer Science, University of Wisconsin - Madison http://www.cs.utexas.edu/~hestness _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
