----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1404/#review3430 -----------------------------------------------------------
src/mem/cache/BaseCache.py <http://reviews.gem5.org/r/1404/#comment3486> The comment should probably be updated src/mem/cache/base.hh <http://reviews.gem5.org/r/1404/#comment3487> I didn't know this style comment was ok. * on each line? src/mem/cache/cache_impl.hh <http://reviews.gem5.org/r/1404/#comment3488> ...to the core -> ...to an upper level? src/mem/cache/cache_impl.hh <http://reviews.gem5.org/r/1404/#comment3489> same as before, not always to the core, could be just upper levels tests/configs/inorder-timing.py <http://reviews.gem5.org/r/1404/#comment3490> Not sure about 80 char and indentation. - Andreas Hansson On Sept. 7, 2012, 12:54 p.m., Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1404/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2012, 12:54 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9211:7e42c10417f2 > --------------------------- > Cache: add a response latency to the caches > > In the current caches the hit latency is paid twice on a miss. This patch lets > a configurable response latency be set of the cache for the backward path. > > > Diffs > ----- > > configs/common/Caches.py 87967784f101 > configs/common/O3_ARM_v7a.py 87967784f101 > src/mem/cache/BaseCache.py 87967784f101 > src/mem/cache/base.hh 87967784f101 > src/mem/cache/base.cc 87967784f101 > src/mem/cache/builder.cc 87967784f101 > src/mem/cache/cache_impl.hh 87967784f101 > tests/configs/inorder-timing.py 87967784f101 > tests/configs/memtest.py 87967784f101 > tests/configs/o3-timing-checker.py 87967784f101 > tests/configs/o3-timing-mp.py 87967784f101 > tests/configs/o3-timing.py 87967784f101 > tests/configs/pc-o3-timing.py 87967784f101 > tests/configs/pc-simple-atomic.py 87967784f101 > tests/configs/pc-simple-timing.py 87967784f101 > tests/configs/realview-o3-checker.py 87967784f101 > tests/configs/realview-o3-dual.py 87967784f101 > tests/configs/realview-o3.py 87967784f101 > tests/configs/realview-simple-atomic-dual.py 87967784f101 > tests/configs/realview-simple-atomic.py 87967784f101 > tests/configs/realview-simple-timing-dual.py 87967784f101 > tests/configs/realview-simple-timing.py 87967784f101 > tests/configs/simple-atomic-mp.py 87967784f101 > tests/configs/simple-timing-mp.py 87967784f101 > tests/configs/simple-timing.py 87967784f101 > tests/configs/tsunami-inorder.py 87967784f101 > tests/configs/tsunami-o3-dual.py 87967784f101 > tests/configs/tsunami-o3.py 87967784f101 > tests/configs/tsunami-simple-atomic-dual.py 87967784f101 > tests/configs/tsunami-simple-atomic.py 87967784f101 > tests/configs/tsunami-simple-timing-dual.py 87967784f101 > tests/configs/tsunami-simple-timing.py 87967784f101 > > Diff: http://reviews.gem5.org/r/1404/diff/ > > > Testing > ------- > > > Thanks, > > Ali Saidi > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
