----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1403/#review3431 -----------------------------------------------------------
src/sim/stat_control.hh <http://reviews.gem5.org/r/1403/#comment3491> A bit of Doxygen would be good. src/sim/stat_control.cc <http://reviews.gem5.org/r/1403/#comment3492> I suggest to move this to the header. src/sim/stat_control.cc <http://reviews.gem5.org/r/1403/#comment3493> Ticks are now unsigned, so this should be unsigned long long I think. Also, the check below can be removed with this update. - Andreas Hansson On Sept. 7, 2012, 12:53 p.m., Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1403/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2012, 12:53 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9210:a8550dc95126 > --------------------------- > Statistics: Add a function to configure periodic stats dumping > > This patch adds a function, periodicStatDump(long long period), which will > dump > and reset the statistics every period. This function is designed to be called > from the python configuration scripts. This allows the periodic stats dumping > to > be configured more easilly at run time. > > The period is currently specified as a long long as there are issues passing > Tick into the C++ from the python as they have conflicting definitions. If the > period is less than curTick, the first occurance occurs at curTick. If the > period is set to 0, then the event is descheduled and the stats are not > periodically dumped. > > Due to issues when resumung from a checkpoint, the StatDump event must be > moved > forward such that it occues AFTER the current tick. As the function is called > from the python, the event is scheduled before the system resumes from the > checkpoint. Therefore, the event is moved using the updateEvents() function. > This is called from simulate.py once the system has resumed from the > checkpoint. > > > Diffs > ----- > > src/python/m5/simulate.py 87967784f101 > src/python/swig/stats.i 87967784f101 > src/sim/stat_control.hh 87967784f101 > src/sim/stat_control.cc 87967784f101 > > Diff: http://reviews.gem5.org/r/1403/diff/ > > > Testing > ------- > > > Thanks, > > Ali Saidi > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
