> On Sept. 11, 2012, 9:39 a.m., Ali Saidi wrote: > > src/unittest/rangetest.cc, line 42 > > <http://reviews.gem5.org/r/1389/diff/1/?file=29427#file29427line42> > > > > maybe keep the test and just don't use the parsing? > > > > Andreas Hansson wrote: > Will do
After quite some time spent on trying to reach a good solution my conclusion is that it is not worth keeping this test. Most of the operators that are used are pruned in the Range<T> -> AddrRange patch that follows, and thus the whole test pretty much disappears. I would rather suggest to stick to the rangemaptest that also includes the basic range functionality and is updated to accommodate the AddrRange class in the follow-up patch. Sounds reasonable? - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1389/#review3439 ----------------------------------------------------------- On Sept. 3, 2012, 9:23 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1389/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2012, 9:23 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9186:caba9377b12a > --------------------------- > AddrRange: Simplify Range by removing stream input/output > > This patch simplifies the Range class in preparation for the > introduction of a more specific AddrRange class that allows > interleaving/striping. > > The only place where the parsing was used was in the unit test. > > > Diffs > ----- > > src/base/SConscript 42807286d6cb > src/base/range.hh 42807286d6cb > src/base/range.cc 42807286d6cb > src/unittest/SConscript 42807286d6cb > src/unittest/rangetest.cc 42807286d6cb > > Diff: http://reviews.gem5.org/r/1389/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
