----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1409/#review3476 -----------------------------------------------------------
Ship it! This looks fine except for the minor formatting thing... just clean that up a bit and there's no need to resubmit src/SConscript <http://reviews.gem5.org/r/1409/#comment3517> this is pretty minor, but the formatting on this line is pretty awkward... why not wrap on a comma in the outer list (which I think could keep this to two lines) rather than bunching everything at the end across four? or you could do it in two steps, assign the flag list to a variable then do: dict(zip(target_types, linker_flags) - Steve Reinhardt On Sept. 11, 2012, 3:12 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1409/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2012, 3:12 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9213:2c3700a56b60 > --------------------------- > scons: Add a target for google-perftools profiling > > This patch adds a new target called 'perf' that facilitates profiling > using google perftools rather than gprof. The perftools CPU profiler > offers plenty useful information in addition to gprof, and the latter > is kept mostly to offer profiling also on non-Linux hosts. > > A small update, after running twolf on ARM with the CPU profiler the > output starts with: > > Total: 96679 samples > 2437 2.5% 2.5% 2561 2.6% TimeBuffer::access (inline) > 2266 2.3% 4.9% 2501 2.6% TimeBuffer::advance > 2263 2.3% 7.2% 2594 2.7% RefCounted::decref (inline) > 2252 2.3% 9.5% 2252 2.3% Stats::StatStor::inc (inline) > 2099 2.2% 11.7% 4711 4.9% RefCountingPtr::del (inline) > 2087 2.2% 13.9% 2087 2.2% SLL_Pop > 1858 1.9% 15.8% 2327 2.4% RefCountingPtr::copy (inline) > 1468 1.5% 17.3% 1468 1.5% tc_new > 1438 1.5% 18.8% 1438 1.5% tc_delete > > For this specific benchmark, the O3 CPU accounts for roughly 85% before > the first memory system function shows up. No free lunch... > > > Diffs > ----- > > src/SConscript 09d63f1e3559 > > Diff: http://reviews.gem5.org/r/1409/diff/ > > > Testing > ------- > > Compiled and ran a few experiments using the perf binary > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
