----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1427/#review3501 -----------------------------------------------------------
src/base/output.cc <http://reviews.gem5.org/r/1427/#comment3527> we probably should do this, but do you know where we're trying to open the same file twice? In that case it probably should happen outside of the if block because a .gz file could have the same issue src/base/stats/text.cc <http://reviews.gem5.org/r/1427/#comment3528> is this going to happen twice now? once here and one by the python that got us here? - Ali Saidi On Sept. 20, 2012, 12:14 p.m., Lluc Alvarez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1427/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2012, 12:14 p.m.) > > > Review request for Default. > > > Description > ------- > > This patch resets/dumps ruby stats when m5 stats are reset/dumped. > > This patch is basically an update of review request #1202, that for some > reason couldn't be applied. This one should work. > > > Diffs > ----- > > src/mem/ruby/system/System.cc c38988024f1f > src/python/swig/stats.i c38988024f1f > src/base/statistics.cc c38988024f1f > src/base/stats/text.cc c38988024f1f > src/mem/ruby/profiler/Profiler.cc c38988024f1f > src/mem/ruby/system/System.hh c38988024f1f > src/base/output.cc c38988024f1f > src/base/statistics.hh c38988024f1f > > Diff: http://reviews.gem5.org/r/1427/diff/ > > > Testing > ------- > > > Thanks, > > Lluc Alvarez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
