----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1428/#review3505 -----------------------------------------------------------
Ship it! Ship It! - Lluc Alvarez On Sept. 20, 2012, 9:58 a.m., Lluc Alvarez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1428/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2012, 9:58 a.m.) > > > Review request for Default. > > > Description > ------- > > This patch ignores the FUTEX_PRIVATE_FLAG of the sys_futex system call in SE > mode. > > With this patch, when sys_futex with the options FUTEX_WAIT_PRIVATE or > FUTEX_WAKE_PRIVATE is emulated, the FUTEX_PRIVATE_FLAG is ignored and so > their behaviours are the regular FUTEX_WAIT and FUTEX_WAKE. > > Emulating FUTEX_WAIT_PRIVATE and FUTEX_WAKE_PRIVATE as if they were > non-private is safe from a functional point of view. The FUTEX_PRIVATE_FLAG > does not change the semantics of the futex, it's just a mechanism to improve > performance under certain circunstances that can be ignored in SE mode. > > > Diffs > ----- > > src/kern/linux/linux.hh c38988024f1f > src/sim/syscall_emul.hh c38988024f1f > > Diff: http://reviews.gem5.org/r/1428/diff/ > > > Testing > ------- > > > Thanks, > > Lluc Alvarez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
