----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1443/#review3529 -----------------------------------------------------------
I have a couple questions: - Why do you modify the msg.sm files? It seems unecessary. - How do you handle functional writes to message buffers no part of the network? As you already know, I'm in favor of just creating a list of message buffers by modifying the MessageBuffer constructor. After seeing the number of files you had to change with this existing patch, I'm further convinced that is the better approach. This current patch seems quite hackish, and adding this support to Garnet is only going to be uglier. What can I do to convince you that the MessageBuffer approach is better? Or in other words, can you explain exactly what you don't like about the MessageBuffer approach? src/mem/protocol/MESI_CMP_directory-dir.sm <http://reviews.gem5.org/r/1443/#comment3542> Whitespace change? src/mem/ruby/slicc_interface/NetworkMessage.hh <http://reviews.gem5.org/r/1443/#comment3541> Why don't you define and implement the functionalWrite function here in NetworkMessage. It seems unecessary to have to modify any .sm files. - Brad Beckmann On Sept. 24, 2012, 6:15 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1443/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2012, 6:15 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9257:5bd46130593a > --------------------------- > ruby: augment network to support functional accesses > This patch adds support to ruby's network subsystem to support functional > accesses. This support exists for the simple network as of now. Later on > Garnet will also support functional accesses. > The patch adds functional access code to all the different types of messages > that protocols can send around. These messages are functionally accessed > by going through the buffers maintained by the network entities. In case of > the simple network, this entity is the Switch structure. > > > Diffs > ----- > > src/mem/protocol/MESI_CMP_directory-dir.sm 73c3eb0dd733 > src/mem/protocol/MESI_CMP_directory-msg.sm 73c3eb0dd733 > src/mem/protocol/MI_example-msg.sm 73c3eb0dd733 > src/mem/protocol/MOESI_CMP_directory-L2cache.sm 73c3eb0dd733 > src/mem/protocol/MOESI_CMP_directory-msg.sm 73c3eb0dd733 > src/mem/protocol/MOESI_CMP_token-L1cache.sm 73c3eb0dd733 > src/mem/protocol/MOESI_CMP_token-msg.sm 73c3eb0dd733 > src/mem/protocol/MOESI_hammer-msg.sm 73c3eb0dd733 > src/mem/protocol/Network_test-msg.sm 73c3eb0dd733 > src/mem/protocol/RubySlicc_Exports.sm 73c3eb0dd733 > src/mem/protocol/RubySlicc_MemControl.sm 73c3eb0dd733 > src/mem/protocol/RubySlicc_Util.sm 73c3eb0dd733 > src/mem/ruby/buffers/MessageBuffer.hh 73c3eb0dd733 > src/mem/ruby/buffers/MessageBuffer.cc 73c3eb0dd733 > src/mem/ruby/buffers/MessageBufferNode.hh 73c3eb0dd733 > src/mem/ruby/network/Network.hh 73c3eb0dd733 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.hh 73c3eb0dd733 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc 73c3eb0dd733 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.hh 73c3eb0dd733 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc 73c3eb0dd733 > src/mem/ruby/network/simple/PerfectSwitch.cc 73c3eb0dd733 > src/mem/ruby/network/simple/SimpleNetwork.hh 73c3eb0dd733 > src/mem/ruby/network/simple/SimpleNetwork.cc 73c3eb0dd733 > src/mem/ruby/network/simple/Switch.hh 73c3eb0dd733 > src/mem/ruby/network/simple/Switch.cc 73c3eb0dd733 > src/mem/ruby/slicc_interface/AbstractController.hh 73c3eb0dd733 > src/mem/ruby/slicc_interface/Message.hh 73c3eb0dd733 > src/mem/ruby/slicc_interface/NetworkMessage.hh 73c3eb0dd733 > src/mem/ruby/slicc_interface/RubyRequest.hh 73c3eb0dd733 > src/mem/ruby/slicc_interface/RubyRequest.cc 73c3eb0dd733 > src/mem/ruby/slicc_interface/RubySlicc_Util.hh 73c3eb0dd733 > src/mem/ruby/system/System.cc 73c3eb0dd733 > src/mem/slicc/ast/TypeDeclAST.py 73c3eb0dd733 > src/mem/slicc/symbols/StateMachine.py 73c3eb0dd733 > src/mem/slicc/symbols/SymbolTable.py 73c3eb0dd733 > src/mem/slicc/symbols/Type.py 73c3eb0dd733 > > Diff: http://reviews.gem5.org/r/1443/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
