> On Sept. 26, 2012, 3:16 p.m., Andreas Hansson wrote: > > configs/example/se.py, line 193 > > <http://reviews.gem5.org/r/1448/diff/2/?file=29950#file29950line193> > > > > Should this be part of the if-statement as well? > > Malek Musleh wrote: > If this is moved to be part of the if-statement, then fatal("CPU > system.cpu0 has no interrupt controller.") in /cpu/base.cc is encountered. > Not sure if its better to do a check on the ISA + system Mode to determine if > fatal should be invoked.
Ok, that's fine then. It's just a bit counter-intuitive to create it always, and only connect the ports in the x86 case. Could you perhaps add a short comment stating that the interrupt controller is always present, but only in the x86 does it have message ports that need to be connected? - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1448/#review3517 ----------------------------------------------------------- On Sept. 26, 2012, 5:46 p.m., Malek Musleh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1448/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2012, 5:46 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9248:1875a911d9a6 > --------------------------- > Configs: SE Script Fix for Alpha+Ruby Simulations. > > PIO Device Interrupts parameters are not found in the ALPHA ISA, only for > x86. Hence running Alpha ISA + Ruby in SE Mode results in a parameters not > found error. > > > Diffs > ----- > > configs/example/se.py 73c3eb0dd7332ff78ac03ab4b1cdc0a17e0650bc > > Diff: http://reviews.gem5.org/r/1448/diff/ > > > Testing > ------- > > > Thanks, > > Malek Musleh > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
