----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1458/#review3545 -----------------------------------------------------------
Ship it! Looks good to me. I'm not aware of any code that uses this object anymore. - Brad Beckmann On Oct. 3, 2012, 9:04 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1458/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2012, 9:04 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9280:ccc2118da290 > --------------------------- > ruby: remove AbstractMemOrCache > The only place where this abstract class is in use is the memory controller, > which it self is an abstract class. Does not seem useful at all. > > > Diffs > ----- > > src/mem/ruby/system/AbstractMemOrCache.hh a5ede748a1d9 > src/mem/ruby/system/MemoryControl.hh a5ede748a1d9 > src/mem/ruby/system/RubyMemoryControl.hh a5ede748a1d9 > > Diff: http://reviews.gem5.org/r/1458/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
