----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1462/#review3548 -----------------------------------------------------------
Ship it! Thanks for the patch. It looks good! - Ali Saidi On Oct. 5, 2012, 3:53 p.m., Tao Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1462/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2012, 3:53 p.m.) > > > Review request for Default. > > > Description > ------- > > The patch is to fix the early termination in multi-core simulation under SE > mode. When "-I" (maximum instruction number) and "-F" (fastforward > instruction number) are applied together, gem5 immediately exits after the > cpu switching. The reason is that multiple exit events may be generated in > the same cycle by Atomic CPU and inserted to mainEventQueue. However, > mainEventQueue can only serve one exit event in one cycle. Therefore, the > rest exit events are left in mainEventQueue without being descheduled or > deleted, which causes gem5 exits immediately after the system resumes by cpu > switching. > > > This addresses bugs SE, early, multi-core, and termination. > http://flyspray.gem5.org/task/SE > http://flyspray.gem5.org/task/early > http://flyspray.gem5.org/task/multi-core > http://flyspray.gem5.org/task/termination > > > Diffs > ----- > > src/sim/simulate.cc a5ede748a1d9 > > Diff: http://reviews.gem5.org/r/1462/diff/ > > > Testing > ------- > > Test done by spec2006 simulation > > > Thanks, > > Tao Zhang > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
