> On Sept. 21, 2012, 9:17 a.m., Nilay Vaish wrote: > > src/base/addr_range.hh, line 134 > > <http://reviews.gem5.org/r/1429/diff/1/?file=29812#file29812line134> > > > > Why do we need to do this? How many characters are we saving any way? > > Andreas Hansson wrote: > The operators are important with the addition of striping. The whole idea > is to hide all the checking for interleaving and matching inside the > AddrRange and never use the start and end outside of this class. I hope that > explains it. > > Nilay Vaish wrote: > Andreas, I wrote to you almost three weeks back that I do not like > overloading the > equality operator for checking whether the address lies in a range. Can > you not just > create a new function?
Sure, I'm happy to do either. The equality operator is only there for historical reasons, that is how it has been done up till this very point. Rather than changing all the places where it is used (and it is quite a few) I was happy to know if anyone else sees a need to change it before going and doing so. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1429/#review3507 ----------------------------------------------------------- On Sept. 21, 2012, 9:50 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1429/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2012, 9:50 a.m.) > > > Review request for Default. > > > Description > ------- > > This patch transitions the bus to use the AddrRange operations instead > of directly accessing the start and end. The change facilitates the > move to a more elaborate AddrRange class that also supports address > striping in the bus by specifying interleaving bits in the ranges. > > Two new functions are added to the AddrRange to determine if two > ranges intersect, and if one is a subset of another. The bus > propagation of address ranges is also tweaked such that an update is > only propagated if the bus received information from all the > downstream slave modules. This avoids the iteration and need for the > cycle-breaking scheme that was previously used. > > > Diffs > ----- > > src/base/addr_range.hh 4672c12307a7 > src/mem/bus.hh 4672c12307a7 > src/mem/bus.cc 4672c12307a7 > > Diff: http://reviews.gem5.org/r/1429/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
