----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1443/#review3581 -----------------------------------------------------------
Ship it! Ship It! - Andreas Hansson On Oct. 15, 2012, 2:15 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1443/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2012, 2:15 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9302:f07b94c9f16e > --------------------------- > ruby: improved support for functional accesses > This patch adds support to different entities in the ruby memory system > for more reliable functional read/write accesses. Only the simple network > has been augmented as of now. Later on Garnet will also support functional > accesses. > The patch adds functional access code to all the different types of messages > that protocols can send around. These messages are functionally accessed > by going through the buffers maintained by the network entities. > The patch also rectifies some of the bugs found in coherence protocols while > testing the patch. > > With this patch applied, functional writes always succeed. But functional > reads can still fail. > > > Diffs > ----- > > configs/example/ruby_mem_test.py 0b9fcd304b58 > src/mem/protocol/MESI_CMP_directory-L1cache.sm 0b9fcd304b58 > src/mem/protocol/MESI_CMP_directory-L2cache.sm 0b9fcd304b58 > src/mem/protocol/MESI_CMP_directory-dir.sm 0b9fcd304b58 > src/mem/protocol/MESI_CMP_directory-msg.sm 0b9fcd304b58 > src/mem/protocol/MI_example-cache.sm 0b9fcd304b58 > src/mem/protocol/MI_example-dir.sm 0b9fcd304b58 > src/mem/protocol/MI_example-msg.sm 0b9fcd304b58 > src/mem/protocol/MOESI_CMP_directory-L1cache.sm 0b9fcd304b58 > src/mem/protocol/MOESI_CMP_directory-L2cache.sm 0b9fcd304b58 > src/mem/protocol/MOESI_CMP_directory-dir.sm 0b9fcd304b58 > src/mem/protocol/MOESI_CMP_directory-msg.sm 0b9fcd304b58 > src/mem/protocol/MOESI_CMP_token-L1cache.sm 0b9fcd304b58 > src/mem/protocol/MOESI_CMP_token-dir.sm 0b9fcd304b58 > src/mem/protocol/MOESI_CMP_token-msg.sm 0b9fcd304b58 > src/mem/protocol/MOESI_hammer-cache.sm 0b9fcd304b58 > src/mem/protocol/MOESI_hammer-dir.sm 0b9fcd304b58 > src/mem/protocol/MOESI_hammer-msg.sm 0b9fcd304b58 > src/mem/protocol/Network_test-msg.sm 0b9fcd304b58 > src/mem/protocol/RubySlicc_Exports.sm 0b9fcd304b58 > src/mem/protocol/RubySlicc_MemControl.sm 0b9fcd304b58 > src/mem/ruby/buffers/MessageBuffer.hh 0b9fcd304b58 > src/mem/ruby/buffers/MessageBuffer.cc 0b9fcd304b58 > src/mem/ruby/buffers/MessageBufferNode.hh 0b9fcd304b58 > src/mem/ruby/network/Network.hh 0b9fcd304b58 > src/mem/ruby/network/simple/PerfectSwitch.cc 0b9fcd304b58 > src/mem/ruby/network/simple/SimpleNetwork.hh 0b9fcd304b58 > src/mem/ruby/network/simple/SimpleNetwork.cc 0b9fcd304b58 > src/mem/ruby/network/simple/Switch.hh 0b9fcd304b58 > src/mem/ruby/network/simple/Switch.cc 0b9fcd304b58 > src/mem/ruby/slicc_interface/AbstractController.hh 0b9fcd304b58 > src/mem/ruby/slicc_interface/Message.hh 0b9fcd304b58 > src/mem/ruby/slicc_interface/NetworkMessage.hh 0b9fcd304b58 > src/mem/ruby/slicc_interface/RubyRequest.hh 0b9fcd304b58 > src/mem/ruby/slicc_interface/RubyRequest.cc 0b9fcd304b58 > src/mem/ruby/slicc_interface/RubySlicc_Util.hh 0b9fcd304b58 > src/mem/ruby/system/MemoryControl.hh 0b9fcd304b58 > src/mem/ruby/system/MemoryControl.cc 0b9fcd304b58 > src/mem/ruby/system/RubyMemoryControl.hh 0b9fcd304b58 > src/mem/ruby/system/RubyMemoryControl.cc 0b9fcd304b58 > src/mem/ruby/system/System.cc 0b9fcd304b58 > src/mem/slicc/ast/TypeDeclAST.py 0b9fcd304b58 > src/mem/slicc/symbols/StateMachine.py 0b9fcd304b58 > src/mem/slicc/symbols/SymbolTable.py 0b9fcd304b58 > src/mem/slicc/symbols/Type.py 0b9fcd304b58 > > Diff: http://reviews.gem5.org/r/1443/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
