----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1474/#review3585 -----------------------------------------------------------
Thanks for posting this Mitch. I've got some minor issues and Andreas does as well, but we really appreciate the contribution. src/cpu/simple/atomic.cc <http://reviews.gem5.org/r/1474/#comment3598> Is tihs actually called? There was a thread on the mailing list about us not doing a good job calling destructors. src/cpu/simple/atomic.cc <http://reviews.gem5.org/r/1474/#comment3599> newline please - Ali Saidi On Oct. 19, 2012, 3:06 p.m., Mitch Hayenga wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1474/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2012, 3:06 p.m.) > > > Review request for Default. > > > Description > ------- > > Add the ability to create SimPoint basic block vector (BBV) files from gem5. > > This patch adds SimPoint profiling functionality to the atomic CPU model. > Normally one has to use another tool like valgrind or pinpoints to perform > this analysis. Using the --simpoint_profile and --simpoint_interval options, > after running simulation a simpoint.bb.gz file will be created in the gem5 > output directory. This file can then be fed to the simpoint tool to identify > program sections representative of overall program behavior. > > > Diffs > ----- > > configs/common/Options.py b4bd51f8b7a0 > configs/example/se.py b4bd51f8b7a0 > src/cpu/simple/AtomicSimpleCPU.py b4bd51f8b7a0 > src/cpu/simple/atomic.hh b4bd51f8b7a0 > src/cpu/simple/atomic.cc b4bd51f8b7a0 > > Diff: http://reviews.gem5.org/r/1474/diff/ > > > Testing > ------- > > Ran a few benchmarks, output simpoint file and selected simpoints seem ok. > > > Thanks, > > Mitch Hayenga > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
