----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1487/ -----------------------------------------------------------
Review request for Default. Description ------- Changeset 9313:cb9c01eda983 --------------------------- ruby: change slicc to allow for constructor args The patch adds support to slicc for recognizing arguments that should be passed to the constructor of a class. I did not like the fact that an explicit check was being carried on the type 'TBETable' to figure out the arguments to be passed to the constructor. The patch also moves some of the member variables that are declared for all the controllers to the base class AbstractController. Diffs ----- src/mem/protocol/MESI_CMP_directory-L1cache.sm f634a34f2f0b src/mem/protocol/MESI_CMP_directory-L2cache.sm f634a34f2f0b src/mem/protocol/MESI_CMP_directory-dir.sm f634a34f2f0b src/mem/protocol/MI_example-cache.sm f634a34f2f0b src/mem/protocol/MI_example-dir.sm f634a34f2f0b src/mem/protocol/MOESI_CMP_directory-L1cache.sm f634a34f2f0b src/mem/protocol/MOESI_CMP_directory-L2cache.sm f634a34f2f0b src/mem/protocol/MOESI_CMP_directory-dir.sm f634a34f2f0b src/mem/protocol/MOESI_CMP_directory-dma.sm f634a34f2f0b src/mem/protocol/MOESI_CMP_token-L1cache.sm f634a34f2f0b src/mem/protocol/MOESI_CMP_token-dir.sm f634a34f2f0b src/mem/protocol/MOESI_hammer-cache.sm f634a34f2f0b src/mem/protocol/MOESI_hammer-dir.sm f634a34f2f0b src/mem/protocol/Network_test-cache.sm f634a34f2f0b src/mem/protocol/RubySlicc_Exports.sm f634a34f2f0b src/mem/ruby/slicc_interface/AbstractController.hh f634a34f2f0b src/mem/ruby/slicc_interface/AbstractController.cc f634a34f2f0b src/mem/slicc/symbols/StateMachine.py f634a34f2f0b Diff: http://reviews.gem5.org/r/1487/diff/ Testing ------- Thanks, Nilay Vaish _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
