----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1481/#review3587 -----------------------------------------------------------
Ship it! not sure my the 92 is tehre ,but overall it looks like a noble effort. configs/common/Caches.py <http://reviews.gem5.org/r/1481/#comment3601> 92? - Ali Saidi On Oct. 24, 2012, 7:14 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1481/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2012, 7:14 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9314:f63537293334 > --------------------------- > config: Use shared cache config for regressions > > This patch uses the common L1, L2 and IOCache configuration for the > regressions that all share the same cache parameters. There are a few > regressions that use a slightly different configuration (memtest, > o3-timing=mp, simple-atomic-mp and simple-timing-mp), and the latter > are not changed in this patch. They will be updated in a future patch. > > The common cache configurations are changed to match the ones used in > the regressions, and are slightly changed with respect to what they > were. Hopefully this means we can converge on a common base > configuration, used both in the normal user configurations and > regressions. > > As only regressions that shared the same cache configuration are > updated, no regressions are affected. > > > Diffs > ----- > > configs/common/Caches.py f634a34f2f0b > tests/configs/o3-timing-mp.py f634a34f2f0b > tests/configs/pc-o3-timing.py f634a34f2f0b > tests/configs/pc-simple-atomic.py f634a34f2f0b > tests/configs/pc-simple-timing.py f634a34f2f0b > tests/configs/realview-o3-checker.py f634a34f2f0b > tests/configs/realview-o3-dual.py f634a34f2f0b > tests/configs/realview-o3.py f634a34f2f0b > tests/configs/realview-simple-atomic-dual.py f634a34f2f0b > tests/configs/realview-simple-atomic.py f634a34f2f0b > tests/configs/realview-simple-timing-dual.py f634a34f2f0b > tests/configs/realview-simple-timing.py f634a34f2f0b > tests/configs/tsunami-inorder.py f634a34f2f0b > tests/configs/tsunami-o3-dual.py f634a34f2f0b > tests/configs/tsunami-o3.py f634a34f2f0b > tests/configs/tsunami-simple-atomic-dual.py f634a34f2f0b > tests/configs/tsunami-simple-atomic.py f634a34f2f0b > tests/configs/tsunami-simple-timing-dual.py f634a34f2f0b > tests/configs/tsunami-simple-timing.py f634a34f2f0b > > Diff: http://reviews.gem5.org/r/1481/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
