----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1490/#review3598 -----------------------------------------------------------
Ship it! Ship It! - Andreas Hansson On Oct. 24, 2012, 2:55 p.m., Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1490/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2012, 2:55 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9309:6c4d8b9cef21 > --------------------------- > Partly revert [4f54b0f229b5] and move draining to m5.changeToTiming > > Changeset 4f54b0f229b5 removed the call to doDrain in changeToTiming > based on the assumption that the system does not need draining when > running in atomic mode. This is a false assumption since at least the > System class requires the system to be drained before it allows > switching of memory modes. This patch reverts that part of the > changeset. > > > Diffs > ----- > > configs/common/Simulation.py f634a34f2f0b > src/python/m5/simulate.py f634a34f2f0b > > Diff: http://reviews.gem5.org/r/1490/diff/ > > > Testing > ------- > > > Thanks, > > Ali Saidi > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
