----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1522/#review3638 -----------------------------------------------------------
Ship it! Seems fine to me! - Nilay Vaish On Oct. 26, 2012, 9:55 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1522/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2012, 9:55 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9318:1c76d65922f3 > --------------------------- > config: Unify caches used in regressions and adjust L2 MSHRs > > This patch unified the L1 and L2 caches used throughout the > regressions instead of declaring different, but very similar, > configurations in the different scripts. > > The patch also changes the default L2 configuration to match what it > used to be for the fs and se scripts (until the last patch that > updated the regressions to also make use of the cache config). The > MSHRs and targets per MSHR are now set to a more realistic default of > 20 and 12, respectively. > > As a result of both the aforementioned changes, many of the regression > stats are changed. A follow-on patch will bump the stats. > > > Diffs > ----- > > configs/common/Caches.py 2daeea4bce1b > tests/configs/inorder-timing.py 2daeea4bce1b > tests/configs/memtest.py 2daeea4bce1b > tests/configs/o3-timing-checker.py 2daeea4bce1b > tests/configs/o3-timing.py 2daeea4bce1b > tests/configs/simple-atomic-mp.py 2daeea4bce1b > tests/configs/simple-timing-mp.py 2daeea4bce1b > tests/configs/simple-timing.py 2daeea4bce1b > > Diff: http://reviews.gem5.org/r/1522/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > Stats update will follow > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
