-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1518/#review3656
-----------------------------------------------------------



src/arch/arm/linux/system.cc
<http://reviews.gem5.org/r/1518/#comment3631>

    Should we have the filename statically defined like this? Or should we have 
a parameter that has this default value?



src/arch/arm/linux/system.cc
<http://reviews.gem5.org/r/1518/#comment3632>

    Can you not store the value of IntReg(2) in a local variable? What is this 
register used for?


- Nilay Vaish


On Oct. 25, 2012, 10:48 a.m., Ali Saidi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/1518/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2012, 10:48 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Description
> -------
> 
> Changeset 9319:49396f5b7637
> ---------------------------
> ARM: dump stats and process info on context switches
> 
> This patch enables dumping statistics and Linux process information on
> context switch boundaries (__switch_to() calls) that are used for
> Streamline integration (a graphical statistics viewer from ARM).
> 
> 
> Diffs
> -----
> 
>   src/arch/arm/ArmSystem.py f634a34f2f0b 
>   src/arch/arm/linux/system.hh f634a34f2f0b 
>   src/arch/arm/linux/system.cc f634a34f2f0b 
>   src/cpu/base.hh f634a34f2f0b 
>   src/cpu/base.cc f634a34f2f0b 
>   src/cpu/pc_event.cc f634a34f2f0b 
>   src/mem/request.hh f634a34f2f0b 
> 
> Diff: http://reviews.gem5.org/r/1518/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ali Saidi
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to