----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1532/#review3678 -----------------------------------------------------------
Ship it! With the addition of a comment it looks good to me src/sim/tlb.hh <http://reviews.gem5.org/r/1532/#comment3645> Perhaps add a comment to make doxygen happy (why don't we just call flushAll?) - Andreas Hansson On Nov. 2, 2012, 10:19 a.m., Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1532/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2012, 10:19 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9358:cef3413ee9ca > --------------------------- > sim, arch: Add support for invalidating TLBs when draining > > This patch adds support for the memInvalidate() drain method. TLB > flushing is requested by calling the virtual flushAll() method on the > TLB. > > Note: This patch renames invalidateAll() to flushAll() on x86 and > SPARC to make the interface consistent across all supported > architectures. > > > Diffs > ----- > > src/arch/sparc/tlb.hh 844f9e724343 > src/arch/sparc/tlb.cc 844f9e724343 > src/arch/x86/isa.cc 844f9e724343 > src/arch/x86/tlb.hh 844f9e724343 > src/arch/x86/tlb.cc 844f9e724343 > src/arch/x86/utility.cc 844f9e724343 > src/sim/tlb.hh 844f9e724343 > > Diff: http://reviews.gem5.org/r/1532/diff/ > > > Testing > ------- > > > Thanks, > > Ali Saidi > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
