----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1537/#review3697 -----------------------------------------------------------
I'd love to see this, but I'd rather see better encapsulation. src/sim/core.hh <http://reviews.gem5.org/r/1537/#comment3652> This should go. src/sim/core.hh <http://reviews.gem5.org/r/1537/#comment3654> This should become: inline Tick curTick { return mainEventQueue.curTick(); } src/sim/core.hh <http://reviews.gem5.org/r/1537/#comment3655> Is this still needed? src/sim/core.cc <http://reviews.gem5.org/r/1537/#comment3653> This should go src/sim/eventq.hh <http://reviews.gem5.org/r/1537/#comment3656> Shouldn't this be private with a public accessor? - Nathan Binkert On Nov. 14, 2012, 2:18 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1537/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2012, 2:18 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9356:84a9103bd1b7 > --------------------------- > sim: have a curTick per eventq > This patch adds a _curTick variable to an eventq. This variable is updated > whenever an event is serviced in function serviceOne(), or all events upto > a particular time are processed in function serviceEvents(). This change > helps when there are eventqs that do not make use of curTick for scheduling > events. > > > Diffs > ----- > > src/sim/core.hh 0fea324c832c > src/sim/core.cc 0fea324c832c > src/sim/eventq.hh 0fea324c832c > src/sim/eventq.cc 0fea324c832c > src/sim/simulate.cc 0fea324c832c > > Diff: http://reviews.gem5.org/r/1537/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
